Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Merging JS and Python binding code - Part 2 #389

Merged
merged 12 commits into from
Jan 23, 2019
Merged

[WIP] Merging JS and Python binding code - Part 2 #389

merged 12 commits into from
Jan 23, 2019

Conversation

timkpaine
Copy link
Member

No description provided.

@timkpaine timkpaine changed the title [WMerging JS and Python binding code [WIP] Merging JS and Python binding code - Part 2 Jan 19, 2019
@texodus
Copy link
Member

texodus commented Jan 23, 2019

Thanks for the PR! This is a great step towards unifying these APIs - I have some anxiety about exposing the C++ types directly, and this helps alot as @sc1f continues to remove this functionality on the JS side, making it easy to extend it on the Python side.

@texodus texodus merged commit a90cdf8 into finos:master Jan 23, 2019
@timkpaine timkpaine deleted the python2 branch November 15, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C++ JS Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkpaine @texodus